Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify feature_store.plan to produce an InfraDiff #2211

Merged
merged 8 commits into from
Jan 11, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR modifies feature_store.plan to produce an InfraDiff object, which will be used to modify infrastructure as part of feast plan.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
sdk/python/feast/diff/FcoDiff.py Outdated Show resolved Hide resolved
sdk/python/feast/diff/infra_diff.py Outdated Show resolved Hide resolved
sdk/python/feast/diff/infra_diff.py Show resolved Hide resolved
sdk/python/feast/infra/infra_object.py Show resolved Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #2211 (87e417a) into master (97dd41e) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
- Coverage   85.04%   85.04%   -0.01%     
==========================================
  Files         105      105              
  Lines        8387     8450      +63     
==========================================
+ Hits         7133     7186      +53     
- Misses       1254     1264      +10     
Flag Coverage Δ
integrationtests 73.08% <52.22%> (-0.52%) ⬇️
unittests 59.84% <66.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 48.37% <0.00%> (ø)
sdk/python/feast/infra/online_stores/datastore.py 89.15% <25.00%> (-2.52%) ⬇️
sdk/python/feast/infra/infra_object.py 72.13% <44.44%> (+0.39%) ⬆️
sdk/python/feast/diff/infra_diff.py 88.40% <46.15%> (-8.42%) ⬇️
sdk/python/feast/errors.py 71.01% <66.66%> (-0.10%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 85.61% <66.66%> (-0.42%) ⬇️
...k/python/feast/infra/online_stores/online_store.py 80.00% <75.00%> (-0.96%) ⬇️
sdk/python/feast/infra/provider.py 89.65% <75.00%> (-0.53%) ⬇️
sdk/python/feast/infra/online_stores/sqlite.py 94.48% <88.88%> (+8.04%) ⬆️
sdk/python/feast/diff/FcoDiff.py 89.09% <100.00%> (+0.62%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97dd41e...87e417a. Read the comment docs.

config: The RepoConfig for the current FeatureStore.
desired_registry_proto: The desired registry, in proto form.
"""
return Infra()
Copy link
Collaborator

@adchia adchia Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonblocking comment: does it make sense to print a message or something here? e.g. so a custom provider knows that feast plan won't cover their use case?

Not sure how we intend the SDK version of plan to be used, so maybe it doesn't make sense to log though.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 2a95629 into feast-dev:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants