Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer redis-py #2221

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Update to newer redis-py #2221

merged 3 commits into from
Jan 20, 2022

Conversation

judahrand
Copy link
Member

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

What this PR does / why we need it:

As of redis-py 4.1 there is a cluster mode included which is based on an improved version of our old dependency. This change will remove a dependency and also allow us to use a newer version of the package.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
sdk/python/setup.py Outdated Show resolved Hide resolved
@pyalex
Copy link
Collaborator

pyalex commented Jan 19, 2022

Hey @judahrand, can you please update requirements/*.txt files as well, so tests would pass?

@judahrand
Copy link
Member Author

Hey @judahrand, can you please update requirements/*.txt files as well, so tests would pass?

I'll do this but I was confused as I could not find the *.in files used to generate them with pip-tools. Am I missing them?

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand
Copy link
Member Author

Hey @judahrand, can you please update requirements/*.txt files as well, so tests would pass?

Ah! Got it make lock-python-dependencies.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #2221 (1697aa0) into master (05f4e8f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2221   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files         105      105           
  Lines        8496     8496           
=======================================
  Hits         7217     7217           
  Misses       1279     1279           
Flag Coverage Δ
integrationtests 73.11% <100.00%> (-0.30%) ⬇️
unittests 59.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/redis.py 94.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f4e8f...1697aa0. Read the comment docs.

@pyalex
Copy link
Collaborator

pyalex commented Jan 19, 2022

/lgtm

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Jan 19, 2022
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit f5912c8 into feast-dev:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants