-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to newer redis-py
#2221
Update to newer redis-py
#2221
Conversation
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Hey @judahrand, can you please update requirements/*.txt files as well, so tests would pass? |
I'll do this but I was confused as I could not find the |
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Ah! Got it |
Codecov Report
@@ Coverage Diff @@
## master #2221 +/- ##
=======================================
Coverage 84.94% 84.94%
=======================================
Files 105 105
Lines 8496 8496
=======================================
Hits 7217 7217
Misses 1279 1279
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com
What this PR does / why we need it:
As of
redis-py
4.1 there is a cluster mode included which is based on an improved version of our old dependency. This change will remove a dependency and also allow us to use a newer version of the package.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: