-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split apply total parse repo #2226
Split apply total parse repo #2226
Conversation
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
f243b66
to
d2aee4a
Compare
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
- Coverage 84.98% 84.92% -0.06%
==========================================
Files 105 105
Lines 8450 8498 +48
==========================================
+ Hits 7181 7217 +36
- Misses 1269 1281 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hey @mickey-liu, this PR looks good to me! would you mind fixing the lint errors and pushing again? you can fix the lint errors with |
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
@felixwang9817 thanks for the review. I just updated the PR with the lint fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, mickey-liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Need a way to pass a user-defined repo to the apply_total method. Added a new method which
apply_total
will now call that takes a RepoContents argWhich issue(s) this PR fixes:
Fixes #2128
Does this PR introduce a user-facing change?: