Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split apply total parse repo #2226

Merged

Conversation

mickey-liu
Copy link
Contributor

@mickey-liu mickey-liu commented Jan 19, 2022

What this PR does / why we need it:
Need a way to pass a user-defined repo to the apply_total method. Added a new method which apply_total will now call that takes a RepoContents arg

Which issue(s) this PR fixes:
Fixes #2128

Does this PR introduce a user-facing change?:

1. Added functionality
2. No User action required
3. added method: apply_total_with_repo_instance()
4. See #2128 

Yun Nan Liu added 7 commits January 19, 2022 11:12
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
fix
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
@mavysavydav
Copy link
Collaborator

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #2226 (59d3986) into master (2a95629) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   84.98%   84.92%   -0.06%     
==========================================
  Files         105      105              
  Lines        8450     8498      +48     
==========================================
+ Hits         7181     7217      +36     
- Misses       1269     1281      +12     
Flag Coverage Δ
integrationtests 73.09% <50.00%> (-0.27%) ⬇️
unittests 59.71% <50.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 48.38% <50.00%> (+0.01%) ⬆️
sdk/python/feast/online_response.py 77.77% <0.00%> (-16.96%) ⬇️
sdk/python/feast/proto_json.py 92.42% <0.00%> (-3.04%) ⬇️
sdk/python/feast/feature_store.py 89.84% <0.00%> (-1.75%) ⬇️
sdk/python/tests/conftest.py 92.07% <0.00%> (-1.18%) ⬇️
.../integration/online_store/test_universal_online.py 97.23% <0.00%> (-0.91%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 94.23% <0.00%> (-0.34%) ⬇️
sdk/python/tests/unit/test_proto_json.py 100.00% <0.00%> (ø)
...n/tests/integration/online_store/test_e2e_local.py 100.00% <0.00%> (ø)
sdk/python/feast/feature_server.py 31.57% <0.00%> (+0.80%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a95629...59d3986. Read the comment docs.

@felixwang9817
Copy link
Collaborator

hey @mickey-liu, this PR looks good to me! would you mind fixing the lint errors and pushing again? you can fix the lint errors with make format-python and make lint-python - see this page for more details

Signed-off-by: Yun Nan Liu <yunnanl@twitter.com>
@mickey-liu
Copy link
Contributor Author

@felixwang9817 thanks for the review. I just updated the PR with the lint fixes.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, mickey-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 62fae05 into feast-dev:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up parse_repo and apply_total
6 participants