Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return UNIX_TIMESTAMP as Python datetime #2244

Merged
merged 4 commits into from
Jan 29, 2022

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Jan 27, 2022

What this PR does / why we need it:

Title is pretty self explanatory. However, it should also be noted that before this PR the unix_timestamp_val and unix_timestamp_list_val attributes of Value were never set. So there was a Proto type which was, as far as I can tell, stored incorrectly.

Because this fixes a bug in how UNIX_TIMESTAMP types are represented in the OnlineStore this change could result in a mix of Python types being returned for UNIX_TIMESTAMP features in existing OnlineStores.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Return `UNIX_TIMESTAMP` as Python `datetime`

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #2244 (dd3f75a) into master (46c4722) will decrease coverage by 25.27%.
The diff coverage is 21.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2244       +/-   ##
===========================================
- Coverage   85.42%   60.14%   -25.28%     
===========================================
  Files         108      108               
  Lines        9027     9028        +1     
===========================================
- Hits         7711     5430     -2281     
- Misses       1316     3598     +2282     
Flag Coverage Δ
integrationtests ?
unittests 60.14% <21.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/integration/registration/test_universal_types.py 35.62% <ø> (-63.13%) ⬇️
sdk/python/feast/type_map.py 42.36% <21.73%> (-26.87%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
.../integration/online_store/test_universal_online.py 15.20% <0.00%> (-82.49%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.71% <0.00%> (-76.29%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c4722...dd3f75a. Read the comment docs.

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 08d6881 into feast-dev:master Jan 29, 2022
feast-ci-bot pushed a commit that referenced this pull request Jan 31, 2022
* Add backticks to left_table_query_string (#2250)

Signed-off-by: david <davidmiller252@gmail.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Delete entity key from Redis only when all attached feature views are gone (#2240)

* Delete entity from redis when the last attached feature view is deleted

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* Delete entity key from Redis only when all attached feature views are gone

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* make lint happy

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* make lint happy

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* one more try with mypy

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* historical_field_mappings2 merge for one sign off commit (#2252)

Signed-off-by: Michelle Rascati <michelle.rascati@sailpoint.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Correct inconsistent dependency (#2255)

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Add snowflake environment variables to allow testing on snowflake infra (#2258)

* add snowflake environment vars to test framework

Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* add snowflake environment vars to test framework

Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Return `UNIX_TIMESTAMP` as Python `datetime` (#2244)

* Refactor `UNIX_TIMESTAMP` conversion

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

* Return `UNIX_TIMESTAMP` types as `datetime` to user

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

* Fix linting errors

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>

* Rename variable to something more sensible

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Feast plan clean up (#2256)

* Run validation and inference on views and entities during plan

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Do not log objects that are unchanged

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Rename Fco to FeastObject

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Remove useless method

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Lint

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Always initialize registry during feature store initialization

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Fix usage test

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Remove print statements

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Squash commits

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Add error type and refactor query execution to have retries

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Handle more snowflake errors

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Fix lint errors

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Fix lint errors

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Fix lint errors

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* Fix wrong import

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* modify registry.db s3 object initialization to work in S3 subdirectory with Java Feast Server (#2259)

Signed-off-by: NalinGHub <nalinm01@gmail.com>
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* clean up docs

Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* lint-python

Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* fixed historical test

Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

* fixed historical test

Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>

Co-authored-by: David Miller <david@patagona.ca>
Co-authored-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Co-authored-by: Michelle Rascati <44408275+michelle-rascati-sp@users.noreply.github.com>
Co-authored-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Co-authored-by: Felix Wang <wangfelix98@gmail.com>
Co-authored-by: Danny Chiao <danny@tecton.ai>
Co-authored-by: Nalin Mehra <37969183+NalinGHub@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants