Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish alternative python package with FEAST_USAGE=False by default #2275

Merged

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Feb 3, 2022

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

There will be two python packages feast and feast-no-telemetry. The last one will have FEAST_USAGE set to False by default.
To minimize maintenance costs as much as possible I solved this issue on the last possible stage - GH workflow job.

Which issue(s) this PR fixes:

Fixes #2235

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2275 (136810d) into master (fc37896) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2275   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files         116      116           
  Lines        9809     9810    +1     
=======================================
+ Hits         8437     8438    +1     
  Misses       1372     1372           
Flag Coverage Δ
integrationtests 74.80% <100.00%> (-0.29%) ⬇️
unittests 58.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/constants.py 100.00% <100.00%> (ø)
sdk/python/feast/usage.py 91.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc37896...136810d. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit ffe82fd into feast-dev:master Feb 3, 2022
@svenharris
Copy link

Hey, I know I'm late to the party but I'm trying install this no telemetry version but I don't know how/where to find it on PyPi (I don't see any mention of it in the docs, nor can I find a version on PyPi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAST_USAGE should default to "False"
6 participants