-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an OFFLINE schema for Snowflake offline store tests #2291
Use an OFFLINE schema for Snowflake offline store tests #2291
Conversation
Signed-off-by: sfc-gh-madkins <miles.adkins@snowflake.com>
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
===========================================
- Coverage 86.15% 58.55% -27.60%
===========================================
Files 116 116
Lines 9820 9820
===========================================
- Hits 8460 5750 -2710
- Misses 1360 4070 +2710
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, sfc-gh-madkins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: sfc-gh-madkins miles.adkins@snowflake.com
What this PR does / why we need it:
Aligns our snowflake testing code with the snowflake testing environment
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: