Add owner field to FeatureService #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2321 +/- ##
===========================================
+ Coverage 58.73% 85.82% +27.08%
===========================================
Files 116 116
Lines 9888 9975 +87
===========================================
+ Hits 5808 8561 +2753
+ Misses 4080 1414 -2666
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
reviewed
Feb 18, 2022
woop
reviewed
Feb 18, 2022
woop
reviewed
Feb 18, 2022
woop
reviewed
Feb 18, 2022
woop
reviewed
Feb 18, 2022
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
/lgtm |
woop
approved these changes
Feb 18, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aht
added a commit
to aht/feast
that referenced
this pull request
Feb 23, 2022
…ents * upstream/master: (103 commits) refactor: Move create cluster script ci: Add validation for upper case PR titles Switch order of views to keep/delete to fix apply logging ci: Fix broken Prow plugin which ignores config.yaml ci: Add PR linting to ensure conventional commits are followed for PR titles Add owner field to FeatureService (feast-dev#2321) Disable Redis cluster tests (feast-dev#2327) Use PR title for commit message Add redis cluster initialziation to master github workflow (feast-dev#2317) Fix materialize bug with RedisCluster (feast-dev#2311) Add support for Dask during historical retrieval (feast-dev#1954) downgrade datatypes to 8 Update pom.xml to 0.18.2 SNAPSHOT Update changelog for 0.18.1 and update pom.xml Update helm chart version Don't require `snowflake` to always be installed (feast-dev#2309) Fixing the Java helm charts and adding a demo tutorial on how to use them (feast-dev#2298) Include infra objects in registry dump and fix Infra's from_proto (feast-dev#2295) Remove old flag warning with the python feature server (feast-dev#2300) podAnnotations Values in the feature-server chart (feast-dev#2304) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds the
ownerfield toFeatureService. It also cleans upFeatureServiceandFeatureViewProjection.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: