-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Have integration tests also run when a PR is LGTM'd #2385
Conversation
Signed-off-by: Danny Chiao <danny@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
==========================================
- Coverage 84.42% 84.35% -0.08%
==========================================
Files 122 122
Lines 10732 10732
==========================================
- Hits 9061 9053 -8
- Misses 1671 1679 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Existing integration tests only run on approval or ok-to-test, when in practice often the last label is actually lgtm
Which issue(s) this PR fixes:
Fixes #