Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added Redshift and Spark typecheck to data_source event_timestamp_col inference #2389

Merged
merged 8 commits into from
Mar 17, 2022
Merged

fix: Added Redshift and Spark typecheck to data_source event_timestamp_col inference #2389

merged 8 commits into from
Mar 17, 2022

Commits on Mar 12, 2022

  1. added Redshift typecheck to data_source event_timestamp_col inference 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    68f6e5e View commit details
    Browse the repository at this point in the history

  2. address comments 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    7f1f15f View commit details
    Browse the repository at this point in the history

  3. moved non file data sources into their own test 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    f6e5907 View commit details
    Browse the repository at this point in the history

  4. addressed comments 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    ca788ce View commit details
    Browse the repository at this point in the history

  5. fixed texts 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    d6703b9 View commit details
    Browse the repository at this point in the history

  6. remove previously defined event_timestamp_column from data_source to … 

    …allow for inference

Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    ef17d06 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. made a deepcopy of data_sources to not affect other tests 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    87981e8 View commit details
    Browse the repository at this point in the history

  2. linter 

    Signed-off-by: Shai Bruhis <shaibruhis@gmail.com>
    @shaibruhis
    shaibruhis committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    302e295 View commit details
    Browse the repository at this point in the history