Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add documentation for custom offline stores #2430

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

kevjumba
Copy link
Collaborator

Signed-off-by: Kevin Zhang kzhang@tecton.ai

What this PR does / why we need it:
Add some documentation on adding offline stores.
Which issue(s) this PR fixes:

Fixes #2411

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
@kevjumba kevjumba requested a review from a team as a code owner March 21, 2022 23:06
@kevjumba kevjumba requested review from pyalex and removed request for a team March 21, 2022 23:06
@kevjumba kevjumba requested review from adchia and removed request for pyalex March 21, 2022 23:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #2430 (5528179) into master (e7dd4b7) will decrease coverage by 26.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2430       +/-   ##
===========================================
- Coverage   83.50%   57.49%   -26.01%     
===========================================
  Files         122      123        +1     
  Lines       10714    10762       +48     
===========================================
- Hits         8947     6188     -2759     
- Misses       1767     4574     +2807     
Flag Coverage Δ
integrationtests ?
unittests 57.49% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/feast/infra/offline_stores/offline_store.py 69.04% <ø> (-14.29%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.50% <0.00%> (-76.50%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 27.04% <0.00%> (-69.19%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 35.18% <0.00%> (-64.82%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dd4b7...5528179. Read the comment docs.

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nits

docs/how-to-guides/adding-a-new-offline-store.md Outdated Show resolved Hide resolved
sdk/python/feast/infra/offline_stores/offline_store.py Outdated Show resolved Hide resolved
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 163cbb4 into feast-dev:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation for abstract pull_all_from_table_or_query offline store method
6 participants