-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add documentation for custom offline stores #2430
chore: Add documentation for custom offline stores #2430
Conversation
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #2430 +/- ##
===========================================
- Coverage 83.50% 57.49% -26.01%
===========================================
Files 122 123 +1
Lines 10714 10762 +48
===========================================
- Hits 8947 6188 -2759
- Misses 1767 4574 +2807
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of nits
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kevin Zhang kzhang@tecton.ai
What this PR does / why we need it:
Add some documentation on adding offline stores.
Which issue(s) this PR fixes:
Fixes #2411