Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for the push source #2461

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

achals
Copy link
Member

@achals achals commented Mar 28, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Last piece in making push sources

Which issue(s) this PR fixes:

Fixes #

@achals achals requested a review from a team as a code owner March 28, 2022 21:21
@achals achals requested review from pyalex and removed request for a team March 28, 2022 21:21
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #2461 (aa1ea79) into master (5352ce7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2461   +/-   ##
=======================================
  Coverage   58.45%   58.45%           
=======================================
  Files         126      126           
  Lines       10780    10780           
=======================================
  Hits         6301     6301           
  Misses       4479     4479           
Flag Coverage Δ
unittests 58.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5352ce7...aa1ea79. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits!

sdk/python/docs/source/index.rst Outdated Show resolved Hide resolved
docs/reference/data-sources/push.md Outdated Show resolved Hide resolved
docs/reference/data-sources/push.md Show resolved Hide resolved
docs/reference/data-sources/push.md Show resolved Hide resolved
docs/reference/data-sources/push.md Show resolved Hide resolved
achals added 3 commits March 28, 2022 19:31
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@kevjumba
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 5acd9c4 into feast-dev:master Mar 29, 2022
@achals achals deleted the achal/push-docs branch March 29, 2022 03:07
jbvaningen pushed a commit to jbvaningen/feast that referenced this pull request Mar 30, 2022
* docs: Add docs for the push source

Signed-off-by: Achal Shah <achals@gmail.com>

* remove bad ref

Signed-off-by: Achal Shah <achals@gmail.com>

* cr

Signed-off-by: Achal Shah <achals@gmail.com>

* cr

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: joostvan <joost.vaningen@adyen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants