Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding workflow to automatically publish new UI releases #2466

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Mar 29, 2022

What this PR does / why we need it:
Automating the release process for the Feast Web UI NPM package (https://www.npmjs.com/package/@feast-dev/feast-ui)

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia requested a review from a team as a code owner March 29, 2022 22:11
@adchia adchia requested review from felixwang9817 and removed request for a team March 29, 2022 22:11
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #2466 (53f60c5) into master (6c55e49) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2466      +/-   ##
==========================================
- Coverage   84.92%   84.91%   -0.01%     
==========================================
  Files         127      127              
  Lines       10853    10862       +9     
==========================================
+ Hits         9217     9224       +7     
- Misses       1636     1638       +2     
Flag Coverage Δ
integrationtests 75.21% <ø> (-0.22%) ⬇️
unittests 58.51% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ython/feast/embedded_go/online_features_service.py 95.08% <0.00%> (-1.64%) ⬇️
sdk/python/feast/on_demand_feature_view.py 95.12% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c55e49...53f60c5. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4e82bee into feast-dev:master Apr 5, 2022
@adchia adchia deleted the feastUIRelease branch July 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants