Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate request feature views (remove it from tests & go) #2477

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Apr 1, 2022

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

Deprecate request feature views (remove it from tests & go).

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex pyalex requested a review from a team as a code owner April 1, 2022 16:27
@pyalex pyalex requested review from felixwang9817 and removed request for a team April 1, 2022 16:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #2477 (df45c91) into master (7c19cf7) will decrease coverage by 26.23%.
The diff coverage is 7.14%.

@@             Coverage Diff             @@
##           master    #2477       +/-   ##
===========================================
- Coverage   84.85%   58.62%   -26.24%     
===========================================
  Files         127      126        -1     
  Lines       10918    10842       -76     
===========================================
- Hits         9265     6356     -2909     
- Misses       1653     4486     +2833     
Flag Coverage Δ
integrationtests ?
unittests 58.62% <7.14%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 56.86% <ø> (-39.25%) ⬇️
...tegration/feature_repos/universal/feature_views.py 35.48% <ø> (-49.14%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.73% <ø> (-76.27%) ⬇️
.../integration/online_store/test_universal_online.py 14.85% <7.14%> (-79.02%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 27.04% <0.00%> (-69.19%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c19cf7...df45c91. Read the comment docs.

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 37971a4 into feast-dev:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants