-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add a source field in the feature view API #2525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
- Coverage 81.99% 81.93% -0.06%
==========================================
Files 140 140
Lines 11745 11757 +12
==========================================
+ Hits 9630 9633 +3
- Misses 2115 2124 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit
@@ -20,7 +20,7 @@ | |||
|
|||
from feast import utils | |||
from feast.base_feature_view import BaseFeatureView | |||
from feast.data_source import DataSource, PushSource | |||
from feast.data_source import DataSource, KafkaSource, KinesisSource, PushSource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should we update docs and tests here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll update docs (and tests)
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
5967091
to
d4b8ca2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Building off #2523 , this PR adds a new
source
field to theFeatureView
API.Which issue(s) this PR fixes:
Fixes #