Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a source field in the feature view API #2525

Merged
merged 7 commits into from
Apr 12, 2022
Merged

chore: Add a source field in the feature view API #2525

merged 7 commits into from
Apr 12, 2022

Conversation

achals
Copy link
Member

@achals achals commented Apr 11, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Building off #2523 , this PR adds a new source field to the FeatureView API.
Which issue(s) this PR fixes:

Fixes #

@achals achals requested a review from a team as a code owner April 11, 2022 20:38
@achals achals requested review from adchia and removed request for a team April 11, 2022 20:38
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #2525 (cb5b31b) into master (6a03bed) will decrease coverage by 0.05%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
- Coverage   81.99%   81.93%   -0.06%     
==========================================
  Files         140      140              
  Lines       11745    11757      +12     
==========================================
+ Hits         9630     9633       +3     
- Misses       2115     2124       +9
Flag Coverage Δ
integrationtests 73.96% <90.47%> (-0.30%) ⬇️
unittests 57.51% <52.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tegration/feature_repos/universal/feature_views.py 83.07% <ø> (ø)
sdk/python/feast/feature_view.py 86.90% <90.47%> (+1.00%) ⬆️
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
...ython/feast/embedded_go/online_features_service.py 96.42% <0.00%> (-0.90%) ⬇️
.../integration/online_store/test_universal_online.py 92.85% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a03bed...cb5b31b. Read the comment docs.

felixwang9817
felixwang9817 reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit

sdk/python/feast/feature_view.py Show resolved Hide resolved
felixwang9817
felixwang9817 reviewed Apr 11, 2022
View reviewed changes
sdk/python/feast/feature_view.py
@@ -20,7 +20,7 @@

from feast import utils
from feast.base_feature_view import BaseFeatureView
from feast.data_source import DataSource, PushSource
from feast.data_source import DataSource, KafkaSource, KinesisSource, PushSource
Copy link
Collaborator

@felixwang9817 felixwang9817 Apr 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should we update docs and tests here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll update docs (and tests)

@achals
chore: Add a source field in the feature view API
81c9d89 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix reference
a81da90 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix reference
2fed4c8 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix reference
3f6bc64 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Start updating tests
3952e12 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fixes
d4b8ca2 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
simpify
cb5b31b 
Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 673d00c into feast-dev:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixwang9817 felixwang9817 felixwang9817 left review comments

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

@woop woop

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@achals @codecov-commenter @feast-ci-bot @adchia @felixwang9817 @woop