Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix typing #2534

Merged
merged 6 commits into from
Apr 14, 2022
Merged

chore: Fix typing #2534

merged 6 commits into from
Apr 14, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR removes Array and String and other Feast types as top-level objects, so that users must do from feast.types import Array, String instead of feast import Array, String.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner April 13, 2022 18:21
@felixwang9817 felixwang9817 requested review from tsotnet and removed request for a team April 13, 2022 18:21
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #2534 (f89ecc6) into master (6f22f22) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
- Coverage   81.78%   81.60%   -0.19%     
==========================================
  Files         141      141              
  Lines       11939    12000      +61     
==========================================
+ Hits         9764     9792      +28     
- Misses       2175     2208      +33     
Flag Coverage Δ
integrationtests 73.56% <77.77%> (-0.61%) ⬇️
unittests 57.63% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/__init__.py 91.30% <ø> (-0.37%) ⬇️
sdk/python/tests/doctest/test_all.py 89.83% <100.00%> (+0.17%) ⬆️
...tegration/feature_repos/universal/feature_views.py 83.33% <100.00%> (ø)
.../integration/online_store/test_universal_online.py 92.59% <100.00%> (-0.84%) ⬇️
...istration/test_universal_odfv_feature_inference.py 100.00% <100.00%> (ø)
...ests/integration/scaffolding/test_partial_apply.py 100.00% <100.00%> (ø)
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
sdk/python/feast/request_feature_view.py 62.50% <0.00%> (-5.07%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f22f22...f89ecc6. Read the comment docs.

@achals
Copy link
Member

achals commented Apr 13, 2022

/lgtm

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Apr 13, 2022
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@felixwang9817 felixwang9817 merged commit fbdd5fc into feast-dev:master Apr 14, 2022
@felixwang9817 felixwang9817 deleted the fix_typing branch April 14, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants