-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix typing #2534
chore: Fix typing #2534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
3778b71
to
db6bfab
Compare
Codecov Report
@@ Coverage Diff @@
## master #2534 +/- ##
==========================================
- Coverage 81.78% 81.60% -0.19%
==========================================
Files 141 141
Lines 11939 12000 +61
==========================================
+ Hits 9764 9792 +28
- Misses 2175 2208 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it: This PR removes
Array
andString
and other Feast types as top-level objects, so that users must dofrom feast.types import Array, String
instead offeast import Array, String
.Which issue(s) this PR fixes:
Fixes #