Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update RTD docs to include spark and trino #2539

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

achals
Copy link
Member

@achals achals commented Apr 13, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from a team as a code owner April 13, 2022 22:25
@achals achals requested review from felixwang9817 and removed request for a team April 13, 2022 22:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #2539 (3131340) into master (11a342f) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
- Coverage   81.77%   81.59%   -0.18%     
==========================================
  Files         141      141              
  Lines       11939    11997      +58     
==========================================
+ Hits         9763     9789      +26     
- Misses       2176     2208      +32     
Flag Coverage Δ
integrationtests 73.56% <ø> (-0.61%) ⬇️
unittests 57.62% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
sdk/python/feast/request_feature_view.py 62.50% <0.00%> (-5.07%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/on_demand_feature_view.py 92.37% <0.00%> (-1.15%) ⬇️
...ython/feast/embedded_go/online_features_service.py 96.42% <0.00%> (-0.90%) ⬇️
.../integration/online_store/test_universal_online.py 92.57% <0.00%> (-0.86%) ⬇️
sdk/python/feast/data_source.py 66.91% <0.00%> (-0.46%) ⬇️
sdk/python/tests/unit/test_data_sources.py 100.00% <0.00%> (ø)
...n/tests/integration/registration/test_inference.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a342f...3131340. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b342436 into feast-dev:master Apr 14, 2022
@achals achals deleted the achal/rtd-docs branch April 14, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants