Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update RedisCluster to use redis-py official implementation #2554

Merged
merged 9 commits into from
Apr 15, 2022
Merged

fix: Update RedisCluster to use redis-py official implementation #2554

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ee665b9
switch to using redis cluster in redis-py
kevjumba Apr 15, 2022
e300263
fix
kevjumba Apr 15, 2022
0109b61
Fix
kevjumba Apr 15, 2022
aec9c28
Fix dependencies
kevjumba Apr 15, 2022
07e2e59
Update py3.7-ci-requirements.txt
felixwang9817 Apr 15, 2022
2861c5a
update 3.10 requirements
kevjumba Apr 15, 2022
1496fa5
Fix dependencies to address issues
kevjumba Apr 15, 2022
7ba4ec8
Fix
kevjumba Apr 15, 2022
03aceb5
Fix
kevjumba Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sdk/python/feast/infra/online_stores/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

try:
from redis import Redis
from rediscluster import RedisCluster
from redis.cluster import ClusterNode, RedisCluster
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError

Expand Down Expand Up @@ -164,7 +164,9 @@ def _get_client(self, online_store_config: RedisOnlineStoreConfig):
online_store_config.connection_string
)
if online_store_config.redis_type == RedisType.redis_cluster:
kwargs["startup_nodes"] = startup_nodes
kwargs["startup_nodes"] = [
ClusterNode(**node) for node in startup_nodes
]
self._client = RedisCluster(**kwargs)
else:
kwargs["host"] = startup_nodes[0]["host"]
Expand Down
Loading