-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Snowflake to AWS Lambda feature server Dockerfile #2565
chore: Add Snowflake to AWS Lambda feature server Dockerfile #2565
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Discussed offline; we're gonna ship this to close out #2560 but a more proper fix needs working on that will make the loading of the online and offline stores lazy. |
Codecov Report
@@ Coverage Diff @@
## master #2565 +/- ##
===========================================
- Coverage 82.81% 59.17% -23.65%
===========================================
Files 141 140 -1
Lines 11947 11835 -112
===========================================
- Hits 9894 7003 -2891
- Misses 2053 4832 +2779
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add Snowflake to AWS Lambda feature server Dockerfile Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Add TODO Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2560