Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct feature statuses during feature logging test #2709

Merged
merged 4 commits into from
May 16, 2022
Merged

fix: Correct feature statuses during feature logging test #2709

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
394ba1e
fix: Feature Logging test & python server ports
pyalex May 16, 2022
ac4f573
optional timedelta
pyalex May 16, 2022
fd8bba9
revert
pyalex May 16, 2022
090a3db
typo
pyalex May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions sdk/python/tests/integration/e2e/test_go_feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import pytest
import pytz

from feast import FeatureService, ValueType
from feast import FeatureService, FeatureView, ValueType
from feast.embedded_go.lib.embedded import LoggingOptions
from feast.embedded_go.online_features_service import EmbeddedOnlineFeatureServer
from feast.feast_object import FeastObject
Expand Down Expand Up @@ -162,13 +162,14 @@ def test_feature_logging(

_, datasets, _ = universal_data_sources
latest_rows = get_latest_rows(datasets.driver_df, "driver_id", driver_ids)
feature_view = fs.get_feature_view("driver_stats")
features = [
feature.name
for proj in feature_service.feature_view_projections
for feature in proj.features
]
expected_logs = generate_expected_logs(
latest_rows, "driver_stats", features, ["driver_id"], "event_timestamp"
latest_rows, feature_view, features, ["driver_id"], "event_timestamp"
)

def retrieve():
Expand Down Expand Up @@ -213,15 +214,26 @@ def get_latest_rows(df, join_key, entity_values):


def generate_expected_logs(
df, feature_view_name, features, join_keys, timestamp_column
df: pd.DataFrame,
feature_view: FeatureView,
features: List[str],
join_keys: List[str],
timestamp_column: str,
):
logs = pd.DataFrame()
for join_key in join_keys:
logs[join_key] = df[join_key]

for feature in features:
logs[f"{feature_view_name}__{feature}"] = df[feature]
logs[f"{feature_view_name}__{feature}__timestamp"] = df[timestamp_column]
logs[f"{feature_view_name}__{feature}__status"] = FieldStatus.PRESENT
col = f"{feature_view.name}__{feature}"
logs[col] = df[feature]
logs[f"{col}__timestamp"] = df[timestamp_column]
logs[f"{col}__status"] = FieldStatus.PRESENT
if feature_view.ttl:
logs[f"{col}__status"] = logs[f"{col}__status"].mask(
df[timestamp_column]
< datetime.utcnow().replace(tzinfo=pytz.UTC) - feature_view.ttl,
FieldStatus.OUTSIDE_MAX_AGE,
)

return logs.sort_values(by=join_keys).reset_index(drop=True)
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def get_local_server_port(self) -> int:
worker_id_num = int(parsed_worker_id[0])
else:
worker_id_num = 0
return 6000 + 100 * worker_id_num + self.id
return 16000 + 100 * worker_id_num + self.id
pyalex marked this conversation as resolved.
Show resolved Hide resolved


def table_name_from_data_source(ds: DataSource) -> Optional[str]:
Expand Down