Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zl/ingestion fixes #286

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Nov 4, 2019

Fixing some issues that the job consolidation in PR #279 caused.
Main issue was that each subgraph consumed from the same consumer group, which caused issues for jobs involving more than 1 feature set.

To remedy this, in this fix, we only have a single read from source node, and fan out from there.

Original ingestion job:

                 +------------+
                 |            |
               +-+  writeRow  |
 +-----------+ | |            |
 |           | | +------------+
 | readKafka +-+                   
 |           | | +------------+
 +-----------+ | |            |
               +-+ writeError |
                 |            |
                 +------------+
.
.
.
                 +------------+
                 |            |
               +-+  writeRow  |
 +-----------+ | |            |
 |           | | +------------+
 | readKafka +-+                   
 |           | | +------------+
 +-----------+ | |            |
               +-+ writeError |
                 |            |
                 +------------+

where each readKafka node shared a single consumer group

Fix:

                                   +-------------+
                                   |             |
                                +--+  writeRows  |
                 +------------+ |  |             |
                 |            | |  +-------------+
              +--+  validate  +-+
              |  |            | |  +-------------+
              |  +------------+ |  |             |
              |                 +--+ writeErrors |
+-----------+ |                    |             |
|           | |        .           +-------------+
| readKafka +-+        .
|           | |        .           +-------------+
+-----------+ |                    |             |
              |                 +--+  writeRows  |
              |  +------------+ |  |             |
              |  |            | |  +-------------+
              +--+  validate  +-+
                 |            | |  +-------------+
                 +------------+ |  |             |
                                +--+ writeErrors |
                                   |             |
                                   +-------------+

2. Move validation outside of read from source
@zhilingc
Copy link
Collaborator Author

zhilingc commented Nov 4, 2019

/retest

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thirteen37, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [thirteen37,zhilingc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-Authored-By: Yu-Xi Lim <thirteen37@users.noreply.github.com>
@thirteen37
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 79eb4ab into feast-dev:0.3-dev Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants