Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implement to_remote_storage for supported offline stores #2918

Merged
merged 14 commits into from
Jul 7, 2022

Conversation

achals
Copy link
Member

@achals achals commented Jul 6, 2022

What this PR does / why we need it:

Following up to #2916 and #2901 by implementing the to_remote_storage methods for Redshift, Snowflake and BigQuery.

The implementation utilizes the native export/unload/copy into functionality present in each of the individual DWHs. There's more configuration possible (such as max file size) but I'm not going to add it into the config just yet.

In fact, a related thought I had is that it would be good to have a way to pass in configuration information (somehow) without needing to make code changes into the config classes.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals changed the title chore: Implement to_remote_storage for RedshiftRetrievalJob chore: Implement to_remote_storage for Redshift and BigQuery Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #2918 (95c548d) into master (109ee9c) will decrease coverage by 21.15%.
The diff coverage is 24.00%.

@@             Coverage Diff             @@
##           master    #2918       +/-   ##
===========================================
- Coverage   80.60%   59.45%   -21.16%     
===========================================
  Files         179      179               
  Lines       15801    15870       +69     
===========================================
- Hits        12737     9435     -3302     
- Misses       3064     6435     +3371     
Flag Coverage Δ
integrationtests ?
unittests 59.45% <24.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/feature_repos/universal/data_sources/bigquery.py 41.17% <0.00%> (-56.87%) ⬇️
.../feature_repos/universal/data_sources/snowflake.py 51.21% <ø> (-48.79%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.36% <0.00%> (-76.64%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 28.90% <18.18%> (-43.05%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 29.02% <18.51%> (-58.68%) ⬇️
sdk/python/feast/infra/offline_stores/snowflake.py 37.60% <32.00%> (-52.92%) ⬇️
sdk/python/feast/infra/offline_stores/redshift.py 37.68% <40.00%> (-53.91%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 76.17% <50.00%> (-17.83%) ⬇️
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109ee9c...95c548d. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Jul 7, 2022
@achals achals changed the title chore: Implement to_remote_storage for Redshift and BigQuery chore: Implement to_remote_storage for Redshift, BigQuery, Snowflake Jul 7, 2022
@achals achals changed the title chore: Implement to_remote_storage for Redshift, BigQuery, Snowflake chore: Implement to_remote_storage for supported offline stores Jul 7, 2022
:

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 7, 2022
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants