Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SDK Ingestion and schema inference updates #307

Merged
merged 12 commits into from
Nov 16, 2019
Merged

Python SDK Ingestion and schema inference updates #307

merged 12 commits into from
Nov 16, 2019

Conversation

woop
Copy link
Member

@woop woop commented Nov 15, 2019

  • Refactor ingestion to use Confluent Kafka Client and to be easier to understand
  • Removed bugs in ingestion that caused broken pipes
  • Add add_fields_from_dataframe method instead of update_from_dataset
  • Refactor loaders module

@woop
Ingestion and schema inference updates
7af40f7 
* Refactor ingestion to use Confluent Kafka Client
* Add add_fields_from_dataframe method instead of update_from_dataset
* Refactor loaders module
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Various ingestion and inference fixes
55080dc 
* Add auto update of feature sets during ingestion
* Add "infer_fields_from_df" method with additional flags for control
* Update e2e tests to make them more modular
@woop
Copy link
Member Author

woop commented Nov 16, 2019

/retest

@woop
Copy link
Member Author

woop commented Nov 16, 2019

/retest

@woop
Copy link
Member Author

woop commented Nov 16, 2019

/retest

@woop
Copy link
Member Author

woop commented Nov 16, 2019

/retest

@woop woop merged commit 0eebd72 into feast-dev:master Nov 16, 2019
@woop
Copy link
Member Author

woop commented Nov 16, 2019

@zhilingc @davidheryanto merging this in so that we can cut a release. Would still be nice if you could have a look at the submission to see if it makes sense.

@feast-ci-bot
Copy link
Collaborator

@woop: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end 4ef98b3 link /test test-end-to-end

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop woop mentioned this pull request Nov 28, 2019
Closed
woop pushed a commit that referenced this pull request Oct 15, 2021
@adchia @gitbook-bot
GitBook: [#307] Update hero image in master
cf82ed6
woop pushed a commit that referenced this pull request Oct 15, 2021
@adchia @gitbook-bot
GitBook: [#307] Adding hero image back to 0.14 branch
83d2654
felixwang9817 pushed a commit that referenced this pull request Oct 20, 2021
@adchia @felixwang9817
GitBook: [#307] Adding hero image back to 0.14 branch
685f72e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pradithya pradithya Awaiting requested review from pradithya

@thirteen37 thirteen37 Awaiting requested review from thirteen37

@tims tims Awaiting requested review from tims

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woop @feast-ci-bot