Refactored Core API: ListFeatureSets, ListStore, and GetFeatureSet #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
woop
commented
Nov 16, 2019
•
woop
commented
- Renamed GetFeatureSets and GetStores to ListFeatureSets and ListStores.
- Implemented GetFeatureSet method
- Implemented wildcard based filtering (to replace regex)
…s, and GetFeatureSet * Updated and implemented in Core * Updated and implemented in Python SDK * Updated serving
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
woop
changed the title
woop
requested review from
davidheryanto,
pradithya,
thirteen37,
tims and
zhilingc
as code owners
* Fix Python Kafka producer bug * Fix comparison between feature sets failing * Fix e2e tests failing due to recreating dataframes
Co-Authored-By: David Heryanto <david.heryanto@hotmail.com>
|
New changes are detected. LGTM label has been removed. |
|
/test test-end-to-end |
Merged
woop
pushed a commit
that referenced
this pull request
Oct 15, 2021
felixwang9817
pushed a commit
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.