Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default job metrics sink to statsd #315

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Change default job metrics sink to statsd #315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fffaef
Change default job metrics sink to statsd
Nov 20, 2019
48b7e8b
Change port to 9125
Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions core/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,12 @@ feast:
metrics:
# Enable metrics pushing for all ingestion jobs.
enabled: false
# Type of metrics sink. Only prometheus is currently supported.
type: prometheus
# Host of the metrics sink. In the case of prometheus, this is the host of the prometheus
# pushGateway to sink metrics to.
# Type of metrics sink. Only statsd is currently supported.
type: statsd
# Host of the metrics sink.
host: localhost
# Port of the metrics sink. In the case of prometheus, this is the port of the prometheus
# pushGateway to sink metrics to.
port: 9091
# Port of the metrics sink.
port: 8125

stream:
# Feature stream type. Only kafka is supported.
Expand Down
4 changes: 2 additions & 2 deletions infra/charts/feast/charts/feast-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ application.yaml:
options: {}
metrics:
enabled: false
type: prometheus
type: statsd
host: localhost
port: 9091
port: 8125
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the container uses 9125. You sure this is right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. I thought it was using the default statsd port

stream:
type: kafka
options:
Expand Down