Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix handling of TTL in Go server #3232

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: Fix handling of TTL in Go server #3232

merged 1 commit into from
Sep 19, 2022

Commits on Sep 19, 2022

  1. Fix handling of TTL in Go server 

    According to the FeatureView docstring, 'A ttl of 0 indicates that this group of features lives forever.'
However, the Go feature server doesn't currently respect this, returning OUTSIDE_MAX_AGE for FeatureViews
that have a TTL of 0. This fixes that issue by always returning false for checkOutsideTtl if the TTL
is 0.

Signed-off-by: William Horton <william.horton@grandrounds.com>
    @wdhorton
    wdhorton committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    bd2c94c View commit details
    Browse the repository at this point in the history