Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure that Snowflake accounts for number columns that overspecify precision #3306

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix: Ensure that Snowflake accounts for number columns that overspecify precision #3306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1935294
fix: Ensure that Snowflake properly accounts for INT32/INT64 columns …
adchia Oct 19, 2022
3b3fbac
fix: Snowflake infer snowflake OBJECT return type for number inference
sfc-gh-madkins Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdk/python/feast/infra/offline_stores/snowflake_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,16 @@ def get_table_column_names_and_types(
result.dtypes[column].name
]
else:
if len(result) > 0:
max_value = result.iloc[0][0]
if max_value is not None and len(str(max_value)) <= 9:
row["snowflake_type"] = "NUMBER32"
continue
elif (
max_value is not None and len(str(max_value)) <= 18
):
row["snowflake_type"] = "NUMBER64"
continue
sfc-gh-madkins marked this conversation as resolved.
Show resolved Hide resolved
raise NotImplementedError(
"NaNs or Numbers larger than INT64 are not supported"
)
Expand Down