feat: Get Snowflake Query Output As Pyspark Dataframe (#2504) #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @sfc-gh-madkins /assign @adchia |
| @@ -447,6 +459,51 @@ def to_sql(self) -> str: | |||
| with self._query_generator() as query: | |||
| return query | |||
|
|
|||
| def to_spark_df( | |||
| self, spark_session: Optional[SparkSession] = None | |||
| ) -> pyspark_DataFrame: | |||
There was a problem hiding this comment.
@amithadiraju1694 can you use just DataFrame here? Not the alias
| spark_df: A pyspark dataframe. | ||
| """ | ||
|
|
||
| if spark_session == None: |
There was a problem hiding this comment.
You should be able to combine these two if statements into one
|
/ok-to-test |
|
@amithadiraju1694 can you run make lint-python |
amithadiraju1694
force-pushed
the
feat_snow_sparkdf
branch
from
29a76b0
to
3816354
Compare
1. Added feature to offline_store-> snowflake.py to return results of snowflake query as pyspark data frame.This helps spark-based users to distribute data, which often doesn't fit in driver nodes through pandas output. 2. Also added relevant error class, to notify user on missing spark session , particular to this usecase. Signed-off-by: amithadiraju1694 <amith.adiraju@gmail.com>
amithadiraju1694
force-pushed
the
feat_snow_sparkdf
branch
from
3816354
to
14c082e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, amithadiraju1694 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevjumba
pushed a commit
that referenced
this pull request
Dec 5, 2022
# [0.27.0](v0.26.0...v0.27.0) (2022-12-05) ### Bug Fixes * Changing Snowflake template code to avoid query not implemented … ([#3319](#3319)) ([1590d6b](1590d6b)) * Dask zero division error if parquet dataset has only one partition ([#3236](#3236)) ([69e4a7d](69e4a7d)) * Enable Spark materialization on Yarn ([#3370](#3370)) ([0c20a4e](0c20a4e)) * Ensure that Snowflake accounts for number columns that overspecify precision ([#3306](#3306)) ([0ad0ace](0ad0ace)) * Fix memory leak from usage.py not properly cleaning up call stack ([#3371](#3371)) ([a0c6fde](a0c6fde)) * Fix workflow to contain env vars ([#3379](#3379)) ([548bed9](548bed9)) * Update bytewax materialization ([#3368](#3368)) ([4ebe00f](4ebe00f)) * Update the version counts ([#3378](#3378)) ([8112db5](8112db5)) * Updated AWS Athena template ([#3322](#3322)) ([5956981](5956981)) * Wrong UI data source type display ([#3276](#3276)) ([8f28062](8f28062)) ### Features * Cassandra online store, concurrency in bulk write operations ([#3367](#3367)) ([eaf354c](eaf354c)) * Cassandra online store, concurrent fetching for multiple entities ([#3356](#3356)) ([00fa21f](00fa21f)) * Get Snowflake Query Output As Pyspark Dataframe ([#2504](#2504)) ([#3358](#3358)) ([2f18957](2f18957))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to offline_store-> snowflake.py to return results of snowflake query as pyspark data frame.This helps spark-based users to distribute data, which often doesn't fit in driver nodes through pandas output.
Also added relevant error class, to notify user on missing spark session , particular to this usecase.
Signed-off-by: amithadiraju1694 amith.adiraju@gmail.com
What this PR does / why we need it:
This adds feature to
SnowflakeRetrievalJobto return result of snowflake query execution as a pyspark data frame.Which issue(s) this PR fixes:
Fixes #2504