Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness checks for Feast services in end to end test #337

Merged
merged 12 commits into from
Dec 22, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented Nov 28, 2019

Feast and Kafka services started in test-end-to-end.sh are not checked for readiness. Errors are only discovered during pytest runs.

This pull request add the readiness checks for those services, so failure to start any of those services will immediately fail end to end test.

By failing early, it's easier to inspect the root cause of failing end to end tests.

Related to #330

…end-to-end

So that any error is discovered early and the last log message is more representative of the actual errors
Netcat cannot check it reliably
To free up resources more quickly and since we our tests do not require more than 1 hour to complete
@woop
Copy link
Member

woop commented Nov 28, 2019

/lgtm

@davidheryanto
Copy link
Collaborator Author

/hold
Doing a bit more testing

@woop
Copy link
Member

woop commented Dec 3, 2019

/lgtm

@woop
Copy link
Member

woop commented Dec 8, 2019

Is this failing because of something else?

@feast-ci-bot feast-ci-bot removed the lgtm label Dec 20, 2019
@davidheryanto
Copy link
Collaborator Author

/hold
Still failing due to this error

org.springframework.beans.BeanInstantiationException: Failed to instantiate [feast.core.model.Source]: Factory method 'getDefaultSource' threw exception; nested exception is java.lang.RuntimeException: org.apache.kafka.common.errors.TimeoutException: Aborted due to timeout.

Value of 1s seems to cause end-to-end test to keep failing due to timeout
@woop
Copy link
Member

woop commented Dec 22, 2019

/retest

@davidheryanto
Copy link
Collaborator Author

/hold cancel

@woop
Copy link
Member

woop commented Dec 22, 2019

/lgtm
/approve

@feast-ci-bot
Copy link
Collaborator

@davidheryanto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end bb2ccdb link /test test-end-to-end

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit 84280d9 into feast-dev:master Dec 22, 2019
@feast-ci-bot
Copy link
Collaborator

@davidheryanto: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

Feast and Kafka services started in test-end-to-end.sh are not checked for readiness. Errors are only discovered during pytest runs.

This pull request add the readiness checks for those services, so failure to start any of those services will immediately fail end to end test.

By failing early, it's easier to inspect the root cause of failing end to end tests.

Related to #330

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants