-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readiness checks for Feast services in end to end test #337
Add readiness checks for Feast services in end to end test #337
Conversation
…end-to-end So that any error is discovered early and the last log message is more representative of the actual errors
Netcat cannot check it reliably
To free up resources more quickly and since we our tests do not require more than 1 hour to complete
/lgtm |
/hold |
- Values are estimated based on previous actual runs of the tests
/lgtm |
Is this failing because of something else? |
…yanto/feast into test-end-to-end-readiness-check
/hold
|
Value of 1s seems to cause end-to-end test to keep failing due to timeout
/retest |
/hold cancel |
/lgtm |
@davidheryanto: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@davidheryanto: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Feast and Kafka services started in test-end-to-end.sh are not checked for readiness. Errors are only discovered during pytest runs.
This pull request add the readiness checks for those services, so failure to start any of those services will immediately fail end to end test.
By failing early, it's easier to inspect the root cause of failing end to end tests.
Related to #330