Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect BigQuery schema creation from FeatureSetSpec #340

Merged
merged 3 commits into from
Nov 29, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented Nov 29, 2019

BOOL value type in FeatureSetSpec is registered as repeated mode in BigQuery, because of incorrect comparison of the type Enum. It should be a single (non repeated) mode.

The comparison:
https://github.com/gojek/feast/blob/1ef1b712b56c00504f37fa4396ed1ebdce625f6a/ingestion/src/main/java/feast/ingestion/utils/StoreUtil.java#L121

The proto for the enum:
https://github.com/gojek/feast/blob/1ef1b712b56c00504f37fa4396ed1ebdce625f6a/protos/feast/types/Value.proto#L34

This pull request:

  1. Add a test to ensure correct BigQuery schema is created.
  2. Compare using the enum name suffix versus the enum int value. This makes the comparison more explicit.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 3b4dcaa into feast-dev:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants