Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Protobuf lower bound to 3.20 to alert that Feast is incompatible with tensorflow #3476

Merged
merged 2 commits into from
Feb 17, 2023
Merged

fix: Protobuf lower bound to 3.20 to alert that Feast is incompatible with tensorflow #3476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b72788
build: protobuf lower bound to 3.20
gbmarc1 Feb 1, 2023
b6d31b8
lint
adchia Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/bigquery_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def get_table_column_names_and_types(
from google.api_core import client_info as http_client_info
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError

raise FeastExtrasDependencyImportError("gcp", str(e))

from google.cloud import bigquery
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"numpy>=1.22,<3",
"pandas>=1.4.3,<2",
"pandavro~=1.5.0", # For some reason pandavro higher than 1.5.* only support pandas less than 1.3.
"protobuf<5,>3",
"protobuf<5,>3.20",
"proto-plus>=1.20.0,<2",
"pyarrow>=4,<9",
"pydantic>=1,<2",
Expand Down