Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump great expectation version #3501

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

sudohainguyen
Copy link
Collaborator

What this PR does / why we need it: bump great expectation dependencies

Which issue(s) this PR fixes:

Fixes #3500

@sudohainguyen sudohainguyen changed the title chore: bump great expectation version chore: Bumb great expectation version Feb 17, 2023
@sudohainguyen sudohainguyen changed the title chore: Bumb great expectation version chore: Bump great expectation version Feb 17, 2023
@sudohainguyen
Copy link
Collaborator Author

/assign @achals

@achals
Copy link
Member

achals commented Mar 2, 2023

Thanks for the PR! Can you also regenerate the requirements files? There's two make commands in Makefile.

Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sudohainguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit ec08a55 into feast-dev:master Mar 3, 2023
@sudohainguyen sudohainguyen deleted the chore/bump_gx_version branch March 3, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Greate Expectations version a bit outdated
3 participants