Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set destination table in BigQuery query config in Feast Batch Serving so it can handle large results #392

Merged
merged 6 commits into from
Dec 26, 2019
Merged

Always set destination table in BigQuery query config in Feast Batch Serving so it can handle large results #392

merged 6 commits into from
Dec 26, 2019

Commits on Dec 25, 2019

  1. Update BQ query config to always set destination table, so that it ca… 

    …n work with large results

Refer to: https://cloud.google.com/bigquery/quotas#query_jobs, maximum reponse-size bullet point.
    @davidheryanto
    davidheryanto committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    15b6d12 View commit details
    Browse the repository at this point in the history

  2. Replace prefix for temp table name

    @davidheryanto
    davidheryanto committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    1360d08 View commit details
    Browse the repository at this point in the history

  3. Set expiry on entity rows table

    @davidheryanto
    davidheryanto committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    937a265 View commit details
    Browse the repository at this point in the history

  4. Include exception message in error description 

    GRPC client such as Feast Python SDK will usually not show error cause only error description
    @davidheryanto
    davidheryanto committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    478407a View commit details
    Browse the repository at this point in the history

  5. Code cleanup

    @davidheryanto
    davidheryanto committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    c52c549 View commit details
    Browse the repository at this point in the history

  6. Update batch-retrieval e2e test. 

    Output rows may not have the same order as requested entity rows
    @davidheryanto
    davidheryanto committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    5381872 View commit details
    Browse the repository at this point in the history