-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change arrow scalar ids usage #4347
chore: Change arrow scalar ids usage #4347
Conversation
This will break all versions below 3.14, won't it? Maybe we should just copy the mapping over instead... Not ideal, but might be better than to depend on an internal helper function. @sudohainguyen wdyt? |
good fix! |
please also check that the change is backward compatible for those who using version less that 3.12 |
@tokoko that's a good point, I think you're right, it would not work 3.12 (but will double check). I think there's three options:
I will work on regenerating the requirements.txt's |
@camenares option 2 also sounds good to me. We can resort to copying the mapping if some other issue arises in the future. Any reason for the upper bound set at P.S. You need to sign all your commits ( |
53ca7f1
to
3ab01e0
Compare
Signed-off-by: Christopher Camenares <ccamenares@gmail.com>
5f34a59
to
7cab31b
Compare
Signed-off-by: Christopher Camenares <ccamenares@gmail.com>
Can you run |
@tokoko yep! Fixing that now, I believe it's related to python/mypy#1153 but testing this locally |
@tokoko I also noticed that allowing the bound to be |
@camenares integration tests failure was unrelated, sorry about that. We accidentally merged a failing PR to master. |
@tokoko Oh! Thanks for that, I just figured it was worth trying |
Signed-off-by: Christopher Camenares <ccamenares@gmail.com>
You will have to regenerate requirements files for the bump to take effect in ci. |
@tokoko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, looks like firebase-admin
lib is pinning with an upper bound, I'll look into that later. lgtm otherwise, thanks a lot
Thanks a lot for the guidance @tokoko , looking forward to more Feast contributions in the future! EDIT: I see |
we have some strict rate limits on cloud services that our tests are often hitting, you can ignore it. |
* Update google-cloud-storage Signed-off-by: Christopher Camenares <ccamenares@gmail.com> * test tighter library restriction Signed-off-by: Christopher Camenares <ccamenares@gmail.com> * fix lint Signed-off-by: Christopher Camenares <ccamenares@gmail.com> * bump <4 again Signed-off-by: Christopher Camenares <ccamenares@gmail.com> --------- Signed-off-by: Christopher Camenares <ccamenares@gmail.com>
[PENDING] 2. Run unit tests and ensure that they are passing: https://github.com/feast-dev/feast/blob/master/CONTRIBUTING.md#unit-tests
What this PR does / why we need it:
Changes where
_ARROW_SCALAR_IDS_TO_BQ
is imported, so thatgoogle-cloud-bigquery
can be bumped. This PR only bumps to 3.13.0, but unblocks further bumping._ARROW_SCALAR_IDS_TO_BQ
was moved here.Which issue(s) this PR fixes:
Related to #3823, but provides a different solution than downgrading.