chore: Define Node.js version with Node Version Manager in Feast UI #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining the Node.js version in a single file makes it easier to use a consistent version and upgrade it in the future. v20.18.0 is the current latest LTS version. Note that the @types/node version numbers don't match the related Node.js version numbers, 20.16.13 is the latest package in the major number 20. setup-node GitHub action node-version-file documentation: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I noticed a TypeScript error in the
FeastUISansProviders.test.tsxfile in VS Code:For whatever reason, I haven't been able to get the error appear elsewhere, e.g. when running the TypeScript compiler. Nonetheless I noticed that we still use Node.js version 16 TypeScript type definitions in the project, and updating those to the latest version 20 definitions makes the error go away. This got me thinking that we don't explicitly define what Node.js version we are supposed to be using, except in the GitHub actions.
So I decided to make a PR and define the Node.js version in a single file to make it easier to use a consistent version and upgrade it in the future. There are a couple alternatives for this, but Node Version Manager is very common and one I've used for years, so I chose it.
v20.18.0 is the current latest LTS version, so let's use that. Note that the @types/node package version numbers don't match the related Node.js version numbers, 20.16.13 is the latest package in the major number 20 series.
Misc
setup-node GitHub action node-version-file documentation: https://github.com/actions/setup-node/blob/v3.8.2/docs/advanced-usage.md