Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SDK #47

Merged
merged 54 commits into from
Jan 17, 2019
Merged

Python SDK #47

merged 54 commits into from
Jan 17, 2019

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Jan 8, 2019

Implementation of the python sdk as outlined in the RFC here: https://github.com/gojek/feast/blob/master/rfcs/0000-python-sdk.md

zhilingc and others added 30 commits January 4, 2019 23:47
Initial commit
a07989e
Add feast resource definitions
0e65567
Add mapping from dtype to valueType
e77ede5
Add utilities for google cloud
5439156
Fix printer to print yaml in order
6c09dfc
Add importer
793fc77
Add client
b3124d2
Update workflow notebook
1edbdc0
Add tests
237b946
Clean up sdk code
1416fe8
Add push to pypi resources
47e4110
Add ValueType and Granularity so that we don't expose internal proto …
4e66d79 
…to client
Scrub sensitve data
7da288e
Add feature_set stub
3b3bcc8
Clean add env, clean up docstrings
0df9c4e
Add create_feature_set implementation
231e803
Move feature set to be a resource
3a9ba39
Add serving retrieval functions
891e3f9
Add FeatureSet and DatasetInfo implementation
7cfad22
Light refactor, fix tests
85b476c
Add checking for different entity in a feature set
5808ccd
Add create_training_dataset api to feast client
09f5a6c
Deduplicate requesting storage specs
6387254
Use TableReference when defining destination table
0bf094d
Fix downloading csv from GCS
5f7bc7b
Add tests and refactoring
ada0335
Refactor and clean move classes locations
5dbeb06
Add license
e30e824
Fix typo
0b3ffee
Move download functionality from DatasetInfo into Client
1c1aaf5
@tims
Copy link
Contributor

tims commented Jan 11, 2019

I like the API. Seems like a great start and we can iterate.

One small thing, I think Datastore should be call FeatureStore, but I'm happy if we refactor that in a new issue.

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 12, 2019
@zhilingc
Copy link
Collaborator Author

I like the API. Seems like a great start and we can iterate.

One small thing, I think Datastore should be call FeatureStore, but I'm happy if we refactor that in a new issue.

/lgtm

Good idea for later versions - we'd have to propagate that name change throughout the system haha.

@woop please review quickstart - I'm still not sure about the dataset since it doesn't showcase our support for real time features, if you can think of a better one I'm open

woop
woop requested changes Jan 12, 2019
View reviewed changes
sdk/python/setup.py Outdated Show resolved Hide resolved
sdk/python/feast/sdk/utils/gs_utils.py Show resolved Hide resolved
sdk/python/feast/sdk/utils/bq_util.py Show resolved Hide resolved
sdk/python/examples/quickstart/Quickstart.ipynb Show resolved Hide resolved
sdk/python/examples/quickstart/Quickstart.ipynb Outdated Show resolved Hide resolved
sdk/python/examples/quickstart/Quickstart.ipynb Show resolved Hide resolved
sdk/python/examples/quickstart/Quickstart.ipynb Outdated Show resolved Hide resolved
sdk/python/examples/quickstart/Quickstart.ipynb Show resolved Hide resolved
core/src/main/java/feast/core/grpc/TrainingServiceImpl.java Outdated Show resolved Hide resolved
@woop
Copy link
Member

woop commented Jan 12, 2019 •
edited
Loading

One small thing, I think Datastore should be call FeatureStore, but I'm happy if we refactor that in a new issue.

Calling it FeatureStore might be confusing because we are calling the complete system a "Feature Store".

@zhilingc
Copy link
Collaborator Author

@woop changes made as requested. Could you review again?

@feast-ci-bot
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot self-assigned this Jan 16, 2019
@tims
Copy link
Contributor

tims commented Jan 17, 2019

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 06cb1ec into feast-dev:master Jan 17, 2019
Yanson pushed a commit to Yanson/feast that referenced this pull request Jul 29, 2020
@ben-voz
KE-805: Add validation logic to spark. (feast-dev#47)
86e8a6b 
KE-805: Add feature validation logic for ingestion with spark.
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request Jul 19, 2024
@tmihalac
Merge pull request feast-dev#47 from tmihalac/add-missing-dependecy-p…
4e0357b 
…ermission-cli

Add missing dependecy permission cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

Assignees

@tims tims

@pradithya pradithya

@woop woop

@feast-ci-bot feast-ci-bot

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhilingc @tims @woop @feast-ci-bot @pradithya