Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Read project data from the 'projects' key while loading the registry state in the Feast UI #4772

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

boliri
Copy link
Contributor

@boliri boliri commented Nov 20, 2024

What this PR does / why we need it:

Starting from 0.41.x releases, the Feast UI is no longer able to load the project summary in the projects overview / landing page. The reason why this is happening is that, after some changes from #4475 got merged into master, the Registry class is unable to build and persist the project's metadata to the backend used as the registry through its method _prepare_registry_for_changes - this behavior has been observed in, at least, the file registry, but it might be applicable to others as well.

Since project's metadata is not generated, and the useLoadRegistry function from the UI is expecting those metadata to exist, the UI fails to render the Project Overview page and hints that the issue might be in the feature_store.yaml, which is not the case.

The purpose of this PR is pretty simple: make the UI extract the project information from the projects array instead of the projectMetadata object while it is refreshing the registry state. With this tiny fix in place, the UI renders components as usual.

Which issue(s) this PR fixes:

Fixes #4743

@boliri boliri requested a review from a team as a code owner November 20, 2024 12:32
@boliri boliri force-pushed the fix/ui/read-project-data-from-projects-key-while-loading-registry-state branch from e4540d1 to 8bb1156 Compare November 20, 2024 12:47
@boliri
Copy link
Contributor Author

boliri commented Nov 20, 2024

I regenerated the registry.db file locally and, after running yarn test, the UI tests passed without issues. However, there's still something wrong in the GitHub Action for these tests as it cannot finish properly:

Error: src/FeastUISansProviders.test.tsx(58,5): error TS2533: Object is possibly 'null' or 'undefined'.
Error: src/queries/useLoadRegistry.ts(55,22): error TS2533: Object is possibly 'null' or 'undefined'.

This might be related to how the proto representation of the Registry is decoded in the UI tests, but I'm not 100% sure.

Thoughts?

EDIT: made some changes to the useLoadRegistry and UI tests are finally passing, but for some reason the job build-docker-image-java won't start 😕

…stry state in the Feast UI

Signed-off-by: boliri <boliri@pm.me>
…s' object

Signed-off-by: boliri <boliri@pm.me>
…te errors in UI builds

Signed-off-by: boliri <boliri@pm.me>
@boliri boliri force-pushed the fix/ui/read-project-data-from-projects-key-while-loading-registry-state branch from 2c09fea to c0f6f93 Compare November 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load UI in 0.41.3
1 participant