-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused ingestion deps #520
Remove unused ingestion deps #520
Conversation
Unused according to `mvn -pl ingestion dependency:analyze`, and tests. We had a recent bump of hibernate-validator with a CVE fix (feast-dev#421) that I was looking to backport, and it turns out it's not used anymore anyway.
/assign @thirteen37 |
Not sure yet whether this is flaky or a legitimate failure, but the failure mode of this test could stand to improve:
I'll see if I can find a quick way to do that. |
/test test-end-to-end-batch |
Thanks for this "housekeeping" pull @ches
Our tests still have a lot of debt as you pointed out elsewhere. Happy to merge this in. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ches, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're getting to the point of running some e2e tests on our infra—sans Prow and sans Google Cloud-dependent tests—so hopefully we can pitch in to ones that bite us. |
* Make dependency:analyze run clean on datatypes-java * Remove stale dependencies from ingestion Unused according to `mvn -pl ingestion dependency:analyze`, and tests. We had a recent bump of hibernate-validator with a CVE fix (feast-dev#421) that I was looking to backport, and it turns out it's not used anymore anyway.
* Make dependency:analyze run clean on datatypes-java * Remove stale dependencies from ingestion Unused according to `mvn -pl ingestion dependency:analyze`, and tests. We had a recent bump of hibernate-validator with a CVE fix (#421) that I was looking to backport, and it turns out it's not used anymore anyway.
What this PR does / why we need it:
Remove unused deps from Ingestion module, for the usual reasons of Good Housekeeping.
My path to this:
hibernate-validator
CVE (though it doesn't relate to library functionality Feast has used)javax.validation
is no longer used anywhere in Feast, there is no need for its API norhibernate-validator
as implementation.Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: