Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runner to string inconsistency #575

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Fix runner to string inconsistency #575

merged 3 commits into from
Mar 27, 2020

Commits on Mar 27, 2020

  1. Changed Runner.getName() to Runner.toString() when passing to Job.run… 

    …ner in DataflowJobManager

This is necessary to standardise the use of Runner.toString() when
passing to the Job.runner, so that code dependending on Job.runner
would know what to expect.
    Zhu Zhanyan committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    dc6ba0e View commit details
    Browse the repository at this point in the history

  2. Document how & when Runner.toString() or Runner.getName() should be used

    Zhu Zhanyan committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    040780a View commit details
    Browse the repository at this point in the history

  3. Convert getName() to toString(). Use name() for Job.runner. 

    Use toString() to render human readable strings while using the
non overriding name() for code dependencies.
    Zhu Zhanyan committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    bb8a3ce View commit details
    Browse the repository at this point in the history