Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error on retrieval of nonexistent feature humanly readable #625

Merged
merged 8 commits into from
Apr 16, 2020
Merged

Make error on retrieval of nonexistent feature humanly readable #625

merged 8 commits into from
Apr 16, 2020

Conversation

mrzzy
Copy link
Collaborator

@mrzzy mrzzy commented Apr 15, 2020

What this PR does / why we need it:
Notifies the user with a human readable error when the user attempts to retrieve
(both online/batch) feature data from feast serving with an feature reference does not match any feature stored in feast.

  • currently the error that the user will see is:
InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.UNKNOWN
	details = ""
	debug_error_string = "{"created":"@1580607090.708289999","description":"Error received from peer ipv4:172.28.0.8:6566","file":"src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"","grpc_status":2}"
>
  • this PR replaces the the error with something more user friendly:
grpc.RpcError: Unable to find feature set for feature ref: (project: s, name: s, version: 1, max_age: )

Which issue(s) this PR fixes:

Fixes #454

Does this PR introduce a user-facing change?:

- Make error on retrieval of nonexistent feature humanly readable.

@woop
Copy link
Member

woop commented Apr 15, 2020

project: s, name: s, version: 1, max_age:

Max age isn't a part of the feature reference, so I think that should be removed.

@woop
Copy link
Member

woop commented Apr 15, 2020

/ok-to-test

@mrzzy
Copy link
Collaborator Author

mrzzy commented Apr 16, 2020

/test test-serving

@mrzzy
Copy link
Collaborator Author

mrzzy commented Apr 16, 2020

/test test-end-to-end

@mrzzy
Copy link
Collaborator Author

mrzzy commented Apr 16, 2020

/test test-end-to-end-batch

@mrzzy
Copy link
Collaborator Author

mrzzy commented Apr 16, 2020

@woop I have removed the max age from the error message.

@woop
Copy link
Member

woop commented Apr 16, 2020

/lgtm
/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrzzy, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit e461cde into feast-dev:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feast Serving should notify users of invalid feature names
3 participants