Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3.7 #670

Merged
merged 3 commits into from
May 1, 2020
Merged

Release v0.3.7 #670

merged 3 commits into from
May 1, 2020

Conversation

woop
Copy link
Member

@woop woop commented May 1, 2020

What this PR does / why we need it:

Releases v0.3.7. I am not sure how much we need this release, but the point is to test out the release process as a wet run of #476.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member Author

woop commented May 1, 2020

/test test-end-to-end-java-8

@woop
Copy link
Member Author

woop commented May 1, 2020

@ches I'm not sure if I have the time to debug the issues on this branch. Are we confident in the changes that have been backported? I think the problem here is likely more the tests/CI than the code.

@ches
Copy link
Member

ches commented May 1, 2020

I thought we had a passing build on #654 and/or #657, I'll take a look at it here.

I am not sure how much we need this release

datatypes-java being published to Central is essential for me to publish an open source release of Scala SDK with the v0.3 support that we use in production. This will close #442 if no one much cares about the v0.3.6 artifacts.

Currently we consume .protos for Scala codegen from an internally-published v0.3.7-SNAPSHOT jar.

@woop
Copy link
Member Author

woop commented May 1, 2020

Error: Unable to access jarfile core/target/feast-core-*-SNAPSHOT.jar

It's looking for the -SNAPSHOT I think

@woop
Copy link
Member Author

woop commented May 1, 2020

Alright, seems fine now. The non-snapshot jar finding needs to be forward ported as well to master.

@woop
Copy link
Member Author

woop commented May 1, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

@woop: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop woop added the lgtm label May 1, 2020
@feast-ci-bot feast-ci-bot merged commit 987cb99 into v0.3-branch May 1, 2020
@ches ches deleted the release-v0.3.7 branch May 1, 2020 11:06
@ches
Copy link
Member

ches commented May 1, 2020

The changelog generation seems slightly off, mostly the 0.3.7 release version itself: its "Full Changelog" link is compare of v0.4.7...v0.3.7 instead of v0.3.6...v0.3.7, which actually includes the Cassandra store, and adding indexes.

There's also a reference to #375 that actually links to 376, not sure if that might have been a mistake in a human edit.

@woop
Copy link
Member Author

woop commented May 1, 2020

The changelog generation seems slightly off, mostly the 0.3.7 release version itself: its "Full Changelog" link is compare of v0.4.7...v0.3.7 instead of v0.3.6...v0.3.7, which actually includes the Cassandra store, and adding indexes.

There's also a reference to #375 that actually links to 376, not sure if that might have been a mistake in a human edit.

I noticed the first problem as well when I created the GitHub release. Will try and figure out why that happened.

The rest of the changelog was copied over from master. I only generated the 0.3.7 contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants