Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include server port config on the generated application.yml #696

Merged
merged 2 commits into from
May 13, 2020

Conversation

khorshuheng
Copy link
Collaborator

What this PR does / why we need it:
By default, Feast serving is listening on port 8081 for http end points. That includes prometheus metrics. The default helm values for Feast Serving targeted port is 8080, which cause Prometheus to scrape the wrong end point.

This PR makes the generated application.yml file override the default http port based on the provided helm values.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator

/lgtm

@khorshuheng
Copy link
Collaborator Author

/test test-end-to-end-batch

@feast-ci-bot feast-ci-bot merged commit 2c5130d into feast-dev:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants