Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to correct compute region #699

Merged
merged 1 commit into from
May 15, 2020

Conversation

terryyylim
Copy link
Member

What this PR does / why we need it:
Ensures compute region tallies with kf-feast's.

Does this PR introduce a user-facing change?:

NONE

@woop
Copy link
Member

woop commented May 13, 2020

/lgtm

@zhilingc
Copy link
Collaborator

/test test-end-to-end-batch

@zhilingc
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

@terryyylim: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end e8e44c1 link /test test-end-to-end
test-end-to-end-batch e8e44c1 link /test test-end-to-end-batch

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop woop merged commit 1df2e70 into feast-dev:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants