Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Feast Core docker image #703

Merged
merged 1 commit into from
May 14, 2020

Conversation

khorshuheng
Copy link
Collaborator

@khorshuheng khorshuheng commented May 14, 2020

What this PR does / why we need it:
The docker build process for Feast Core is currently broken. Eg. http://prow.feast.ai/spyglass/lens/buildlog/iframe?req=%7B%22artifacts%22%3A%5B%22build-log.txt%22%5D%2C%22index%22%3A1%2C%22src%22%3A%22gcs%2Ffeast-templocation-kf-feast%2Flogs%2Fpublish-docker-images%2F1260750880961990656%22%7D&topURL=http%3A//prow.feast.ai/view/gcs/feast-templocation-kf-feast/logs/publish-docker-images/1260750880961990656&lensIndex=1#build-log.txt:3250

The root cause is due to wget not being available in maven slim docker image.

We can either use the non-slim variant, which is the approach taken by Feast Serving, or install wget as part of the build step. For this PR, i chose the former.

There is also another problem where the publish docker image (pre-submit) is failing, due to wrong argument passed to docker. Removed the steps as the docker push process is already covered by the script.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator

/lgtm

@zhilingc
Copy link
Collaborator

/lgtm

@khorshuheng khorshuheng merged commit 963a23f into feast-dev:master May 14, 2020
@feast-ci-bot
Copy link
Collaborator

@khorshuheng: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

What this PR does / why we need it:
The docker build process for Feast Core is currently broken. Eg. http://prow.feast.ai/spyglass/lens/buildlog/iframe?req=%7B%22artifacts%22%3A%5B%22build-log.txt%22%5D%2C%22index%22%3A1%2C%22src%22%3A%22gcs%2Ffeast-templocation-kf-feast%2Flogs%2Fpublish-docker-images%2F1260750880961990656%22%7D&topURL=http%3A//prow.feast.ai/view/gcs/feast-templocation-kf-feast/logs/publish-docker-images/1260750880961990656&lensIndex=1#build-log.txt:3250

The root cause is due to wget not being available in maven slim docker image.

We can either use the non-slim variant, which is the approach taken by Feast Serving, or install wget as part of the build step. For this PR, i chose the former.

There is also another problem where the publish docker image (pre-submit) is failing, due to wrong argument passed to docker. Removed the steps as the docker push process is already covered by the script.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

@khorshuheng: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-batch 527ce09 link /test test-end-to-end-batch

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants