Expand Go and Java SDK Test Coverage #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzzy
requested review from
davidheryanto,
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
woop
reviewed
May 21, 2020
|
/hold |
zhilingc
reviewed
May 21, 2020
|
/hold cancel |
mrzzy
changed the title
added 6 commits
June 5, 2020 11:49
…s retrieval" This reverts commit 13008ccef6b6cbee6299029589b5e9e864eee7ae.
woop
approved these changes
Jun 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
zhangchi1
pushed a commit
to Cimpress-MCP/feast
that referenced
this pull request
Jun 11, 2020
* Added TestGetOnlineFeatures() client_test to test client.GetOnlineFeatures() * Added unit test for Java SDK's FeastClient * Make Python SDK's client.get_online_features() unit test more comprehensive * Remove code added to debug the Python SDK tests * Change repo referenced in go.mod to mrzzy fork to test modules retrieval * Fix python sdk lint * Revert "Change repo referenced in go.mod to mrzzy fork to test modules retrieval" This reverts commit 13008ccef6b6cbee6299029589b5e9e864eee7ae. * Optmisation: Init stripFields map to expected size in client.GetOnlineFeatures() * Make the name of the client test case more descriptive * Add missing mock files * Fix rebase markers in project root go mod * Fix compilation issue cause by downgrade to java 8 * Revert row count in python SDK client test to 300 Co-authored-by: Zhu Zhanyan <zhu.zhanyan@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Expand SDKs Test Coverage:
FeastClientin Java SDK.Client.get_online_features()in Python SDK to verify the correct request is submitted.Does this PR introduce a user-facing change?: