Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Feast Java SDK and Ingestion compatibility with Java 8 runtimes #722

Merged
merged 2 commits into from
May 22, 2020
Merged

Restore Feast Java SDK and Ingestion compatibility with Java 8 runtimes #722

merged 2 commits into from
May 22, 2020

Commits on May 21, 2020

  1. Make storage modules target Java 8, since Ingestion must 

    With the addition of the Storage APIs and connector implementations, we
did not specify that their build should target Java 8 bytecode. Because
Ingestion depends on them, we regressed on keeping Ingestion compatible
with Java 8 runtimes according to feast-dev#518.

This could be confirmed prior to this change with, for example:

    $ mvn -pl ingestion clean compile
    $ javap -v storage/connectors/redis/target/classes/feast/storage/connectors/redis/writer/RedisCustomIO.class | grep major
      major version: 55

I take this as proof that a blacklist approach with 11 as the default in
our root POM is error prone, so this change flips it so that 8 is
default and our leaf applications that are able use 11 opt into it in
whitelist fashion.
    @ches
    ches committed May 21, 2020
    Configuration menu
    Copy the full SHA
    7b1e820 View commit details
    Browse the repository at this point in the history

  2. Target Java 8 compatibility for Java SDK

    @ches
    ches committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2e0c16a View commit details
    Browse the repository at this point in the history