Consolidate ingestion jobs to one job per source #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
pyalex
force-pushed
the
one-job-per-source
branch
4 times, most recently
from
7a98f56
to
a3a2217
Compare
|
/test test-end-to-end-batch-dataflow |
|
/test test-end-to-end-batch |
|
To be clear, the consolidation is to reduce the amount of simultaneous jobs. |
woop
reviewed
Jun 23, 2020
woop
reviewed
Jun 23, 2020
woop
reviewed
Jun 23, 2020
woop
reviewed
Jun 23, 2020
core/src/main/java/feast/core/service/JobCoordinatorService.java
Outdated
Show resolved
Hide resolved
woop
reviewed
Jun 23, 2020
woop
changed the title
pyalex
changed the title
woop
reviewed
Jun 23, 2020
woop
reviewed
Jun 23, 2020
pyalex
force-pushed
the
one-job-per-source
branch
from
731d491
to
24492d0
Compare
|
/lgtm |
woop
approved these changes
Jun 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
All IngestionJobs assigned to the same physical source are now consolidated into one that writes to all sinks subscribed to this source.
Refactoring:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: