Prevent reserved fields from being registered #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
changed the title
|
/test test-end-to-end |
woop
reviewed
Jun 23, 2020
|
|
||
| private static void checkReservedColumns(List<FeatureSpec> featureSpecs) { | ||
| List<String> reservedNames = | ||
| Arrays.asList("created_timestamp", "event_timestamp", "ingestion_id", "job_id"); |
There was a problem hiding this comment.
These should be defined elsewhere as constants, not within the method. You can at least hoist it to the top of the class as a field.
woop
reviewed
Jun 23, 2020
| if (reservedNames.contains(featureSpec.getName())) { | ||
| throw new IllegalArgumentException( | ||
| String.format( | ||
| "Reserved feature names have been used, which are not allowed. These names include %s.", |
There was a problem hiding this comment.
Please include the field the user tried to register as well.
|
/test test-end-to-end-batch |
2 similar comments
|
/test test-end-to-end-batch |
|
/test test-end-to-end-batch |
pyalex
approved these changes
Jun 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
ches
added
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR prevents applying of Featuresets with Feature names that are reserved.
Which issue(s) this PR fixes:
Fixes #818
Does this PR introduce a user-facing change?: