Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure store subscriptions are migrated to allow exclusion schema #838

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jun 29, 2020

What this PR does / why we need it:

To keep stores consistent (not only in proto) we migrate subscriptions explicitly

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@terryyylim
Copy link
Member

/test publish-docker-images

@pyalex
Copy link
Collaborator Author

pyalex commented Jun 29, 2020

/retest

@woop woop changed the title Migrate store's subscription Ensure store subscriptions are migrated to allow exclusion schema Jun 29, 2020
@woop
Copy link
Member

woop commented Jun 29, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 7980e33 into feast-dev:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants