Fix Python SDK ingestion for featureset name that exist in multiple projects #868
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
|
/retest |
sdk/python/feast/client.py
Outdated
| >>> "rating": [4.3], | ||
| >>> } | ||
| >>> ) | ||
| >>> client.ingest("project1:driver", fs_df) |
There was a problem hiding this comment.
project:feature_set is not a valid feature reference. It would be better to have a project key on the method, or even look at the project that the user has configured in their environment.
|
All bug fixes need release notes. Also, please dont use Finally, you also need to have tests to ensure that this functionality is working. |
terryyylim
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
* Fix ingestion with same featureset name * Address PR comments * Remove unrelated test * Remove unnecessary line Co-authored-by: Terence <terence.limxp@go-jek.com> Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
What this PR does / why we need it:
Current, Python SDK client will always ingest into
defaultproject's featureset, even if project is known in FeatureSet object.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: