Add IngestionId & EventTimestamp to FeatureRowBatch to calculate lag metric correctly #874
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
|
/lgtm |
|
/lgtm |
|
/retest |
|
Good feedback that we have received in the past is that we should be updating the release note with the bug as well as mentioning when the bug was introduced. |
So metrics on BQ never worked, since it didn't produce output before 0.6. But we can say that bug was introduced with 0.6 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test test-end-to-end-auth |
|
/lgtm |
|
/lgtm |
…metric correctly (feast-dev#874) * ingestionId & eventTimestamp in FeatureRowBatch * refactor idx operations using schema * dummy Co-authored-by: Oleksii Moskalenko <oleksii.moskalenko@go-jek.com>
…metric correctly (#874) * ingestionId & eventTimestamp in FeatureRowBatch * refactor idx operations using schema * dummy Co-authored-by: Oleksii Moskalenko <oleksii.moskalenko@go-jek.com>
What this PR does / why we need it:
Currently row based metrics (like lag) are calculated incorrectly due to absence of correct timestamp in FeatureRow.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: